When company is a mention, link it #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golles
commented
Jul 9, 2022
| @@ -42,6 +42,14 @@ const ListItem = ({ icon, title, value, link, skeleton = false }) => { | |||
| ); | |||
| }; | |||
|
|
|||
| const isCompanyMention = (company) => { | |||
| return company.startsWith('@') && !company.includes(' '); | |||
There was a problem hiding this comment.
I'm not fully sure what the exact rules are for a mention, I think a mention should start with a @ and cannot contain spaces.
golles
commented
Jul 9, 2022
| }; | ||
|
|
||
| const companyLink = (company) => { | ||
| return `https://github.com/${company.substring(1)}`; |
There was a problem hiding this comment.
Strip first character (@)
arifszn
approved these changes
Jul 9, 2022
| @@ -42,6 +42,14 @@ const ListItem = ({ icon, title, value, link, skeleton = false }) => { | |||
| ); | |||
| }; | |||
|
|
|||
| const isCompanyMention = (company) => { | |||
| return company.startsWith('@') && !company.includes(' '); | |||
| }; | ||
|
|
||
| const companyLink = (company) => { | ||
| return `https://github.com/${company.substring(1)}`; |
Thanks, this is all. You can merge it :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please advise if this is the best way of doing this.