Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: add support for migrate down #141

Merged
merged 3 commits into from
Mar 26, 2024
Merged

all: add support for migrate down #141

merged 3 commits into from
Mar 26, 2024

Conversation

masseelch
Copy link
Member

@masseelch masseelch commented Mar 22, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Atlas Lint Report

Analyzed migrations

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks
Migrations automatically reviewed by Atlas

@github-actions GitHub Actions
Copy link

Atlas Lint Report

Analyzed migrations2

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks
Migrations automatically reviewed by Atlas

@masseelch masseelch force-pushed the j/down branch 22 times, most recently from b9147af to 123df74 Compare March 25, 2024 16:56
@masseelch masseelch requested review from rotemtam, a8m, ronenlu and a team March 25, 2024 16:58
@masseelch masseelch force-pushed the j/down branch 2 times, most recently from f3926d4 to 8183150 Compare March 25, 2024 17:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

atlas migrate lint on atlasaction/testdata/migrations_destructive

Status Step Link
1 new migration file detected  
ERD and Visual Diff generated View Visualization
1 error found Full Report

Migrations automatically reviewed with Atlas

ronenlu
ronenlu reviewed Mar 25, 2024
View reviewed changes
atlasaction/action.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Mar 25, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
a8m
a8m reviewed Mar 25, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
a8m
a8m reviewed Mar 25, 2024
View reviewed changes
atlasaction/action.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Mar 25, 2024
View reviewed changes
atlasaction/action.go Outdated Show resolved Hide resolved
a8m
a8m reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

ronenlu
ronenlu reviewed Mar 25, 2024
View reviewed changes
atlasaction/action_test.go Outdated Show resolved Hide resolved
ronenlu
ronenlu reviewed Mar 25, 2024
View reviewed changes
migrate/down/action.yml Outdated Show resolved Hide resolved
@masseelch masseelch requested review from a8m and ronenlu March 26, 2024 09:18
a8m
a8m reviewed Mar 26, 2024
View reviewed changes
atlasaction/action.go Outdated Show resolved Hide resolved
@masseelch masseelch requested a review from a8m March 26, 2024 09:27
@masseelch masseelch merged commit bac4d54 into master Mar 26, 2024
8 checks passed
@masseelch masseelch deleted the j/down branch March 26, 2024 09:28
@masseelch masseelch mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m a8m approved these changes

@rotemtam rotemtam Awaiting requested review from rotemtam

@ronenlu ronenlu Awaiting requested review from ronenlu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masseelch @a8m @ronenlu