Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update base cloud url to api instead of ingress #50

Merged
merged 3 commits into from
Mar 7, 2023
Merged

update base cloud url to api instead of ingress #50

merged 3 commits into from
Mar 7, 2023

Conversation

ronenlu
Copy link
Member

@ronenlu ronenlu commented Mar 7, 2023 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Atlas Lint Report

Analyzed migrations

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks
Migrations automatically reviewed by Atlas

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Atlas Lint Report

Analyzed migrations2

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks
Migrations automatically reviewed by Atlas

ronenlu
ronenlu commented Mar 7, 2023
View reviewed changes
__tests__/atlas.test.ts
Comment on lines -150 to -153
{
Name: 'Migration Integrity Check',
Text: 'File atlas.sum is valid'
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this PR,
failed the tests on master branch, so I fixed it on the way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what changed?

@ronenlu ronenlu requested review from rotemtam, masseelch and a team March 7, 2023 12:15
@ronenlu ronenlu merged commit 975bc8b into master Mar 7, 2023
@dorav dorav deleted the base_cloud_url branch November 2, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemtam rotemtam rotemtam approved these changes

@masseelch masseelch Awaiting requested review from masseelch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronenlu @rotemtam