Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/sqlite: migrate table options #1769

Merged
merged 2 commits into from
Jun 22, 2023
Merged

sql/sqlite: migrate table options #1769

merged 2 commits into from
Jun 22, 2023

Conversation

noamcattan
Copy link
Member

No description provided.

@noamcattan noamcattan requested review from a8m and masseelch June 21, 2023 11:47
sql/sqlite/migrate.go Outdated Show resolved Hide resolved
sql/sqlite/diff.go Outdated Show resolved Hide resolved
sql/sqlite/migrate.go Outdated Show resolved Hide resolved
@noamcattan noamcattan force-pushed the sqlite_options_migrate branch 4 times, most recently from bf1def9 to 8c2b690 Compare June 21, 2023 14:25
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comment before approving.

sql/sqlite/migrate_test.go Outdated Show resolved Hide resolved
sql/sqlite/migrate_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants