Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize RPC server components. #5

Merged
merged 95 commits into from
Dec 23, 2022
Merged

Stabilize RPC server components. #5

merged 95 commits into from
Dec 23, 2022

Conversation

arindas
Copy link
Owner

@arindas arindas commented Dec 23, 2022

  • Migrated copy-on-write pointers to generic byte containers to avoid hidden clones.
  • Formalized the server RPC API for single node deployments
  • Designed and implemented the execution model for processing requests in our RPC server:
    • Formalized abstract generic interfaces that can be implemented for different async runtimes
    • Provided a concrete implementation for glommio runtime.
  • Added crucial documentation on the internals of laminarmq

@arindas
Added types for managing partitions.
67375fd
@arindas
Seperated modules to individual files.
dd432ea
@arindas
Moved segment and store modules inside segmented_log
7677ced
@arindas
Removed unnecessary type aliases.
7f9bb3a
@arindas
Updated doc for commit_log/glommio_impl
2d34779
@arindas
Adhere to 2018 mod structure convention.
137d7f9
@arindas
Moved mod partition to a seperate file.
0163f19
@arindas
Formalized the Partition trait and Shard type.
9550587
@arindas
Added worker implementation for glommio
a9d4bf9
@arindas
Use concrete glommio specific sender go glommio processor impl
4d129b8
@arindas
Made read() Record returns more generic in terms of lifetime.
9bc75fd
@arindas
Removed server::executor::Executor trait, and corresponding impl.
313b844
@arindas
Added an in memory partition implementation for testing.
7d834c4
@arindas
Handle creation and deletion of partitions.
bfee17c
@arindas
Moved Request, Response to mod server
c75fabc
@arindas
Check if partition is still in use before removing.
d16396c
@arindas
Refactored partition removal into a state machine.
bc37ea1
@arindas
Added tests for PartitionRemover
4868937
@arindas
Added utlities and increased uniformity.
555170a 
- Made server::glommio_impl::hyper_compat::HyperExecutor spawn futures
  on task queues.
- Add utiltity constructuors for tasks and processors under
  glommio_impl.
@arindas
Refactored glommio_impl::segment::<Segment::new> to a normal function…
a794b63 
… to avoid name clashes.
@arindas
Partial commit for server::glommio_impl::processor::test
b431a44
@arindas
Added tests for server::glommio_impl::processor
d6495a5
@arindas
Old tests always used default value of store buffer size; made it exp…
be33756 
…licit.
@arindas
Added a partition hierachy request type.
7aca0e6
@arindas
Handle partition close() with Drop impl
f20a3c7
@arindas
Added an expired_storage() method in the CommitLog trait.
a61ade1
@arindas
Made Partition generic wrt Request, Response. Made Processor impl und…
be83ed5 
…er glommio_impl more specific.
@arindas
Moved single node specific entities to nested module.
8cd0034
@arindas
Replaced log with tracing, ensured tests validity.
c1a441e
@arindas
Moved single node specific entities in server::partition to nested mo…
0411ddb 
…dule.
@arindas
Removed redundant binalt abstraction as it is mostly used in place of…
788acb8 
… a Result.
@arindas
Added tests for commit_log::segmented_log::truncate()
0c444cc
@arindas
Remove unnecessary lifetime in glommio_impl/mod.rs doc comment code e…
284c9cb 
…xample.
@arindas
Improved documentation under commit_log/
eb1e025
@arindas
Improved README and lib.rs docs.
5c711f0
@arindas
Fixed links in documentation.
e4e01bd
@arindas
Added documentation for server::{single_node, worker, tokio_compat}
da8fabc
@arindas
Updated README with diagram for segmented log.
b871d4d
@arindas
Corrected coninuation dashes in segmented log diagram.
4494c06
@arindas
Centered labels in segmented-log diagram.
9d8a342
@arindas
Centered labels in segmented-log diagram.
ff7c69e
@arindas
Clarified position and offset calculations further. Explicitly specif…
a987920 
…ied offset for new record in README.
@arindas
Maded the testing section in the README more accessible.
e6902e7
@arindas
Clarified state of testing on WSL
5274edc
@arindas
Added missing documentation for different modules.
8674aa8
@arindas
Corrected doc links.
3fea11f
@arindas
Added documentation for items under common/
ab42b4e
@arindas
Added documentation for record metadata in segmented_log.
995bc2c
@arindas
Made lib.rs design section consistent with README.
34a4beb
@arindas
Improved documentation for partition::single_node::commit_log::Partition
d959fd7
@arindas
Removed trailing spaces in docs.
e7b7854
@arindas
Added missing docs for PartitionId and PartitionRequest.
4282d06
@arindas
Corrected typos and added missing documentation where necessary.
09d11ff
@arindas
Merge pull request #3 from arindas/enhancement/readme-lib-rs-docs
6915da8 
Overhaul documentation in different modules
@arindas
Use single job for cargo tarpaulin
fe50c32
@arindas
Merge pull request #4 from arindas/feature/server
a07ae47 
Added necessary pieces of RPC Server implementation
@arindas
Updated crate version to prepare for release.
14e3233
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022 •
edited
Loading

Codecov Report

Base: 80.85% // Head: 68.89% // Decreases project coverage by -11.96% ⚠️

Coverage data is based on head (ea107ca) compared to base (ca0f228).
Patch coverage: 68.65% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
- Coverage   80.85%   68.89%   -11.97%     
===========================================
  Files           6       21       +15     
  Lines         700      942      +242     
===========================================
+ Hits          566      649       +83     
- Misses        134      293      +159
Impacted Files Coverage Δ
src/lib.rs 0.00% <ø> (ø)
src/server/glommio_impl/hyper_compat.rs 0.00% <0.00%> (ø)
src/server/router.rs 0.00% <0.00%> (ø)
src/server/tokio_compat.rs 0.00% <0.00%> (ø)
src/server/worker.rs 47.36% <47.36%> (ø)
src/server/partition/single_node/commit_log.rs 58.82% <58.82%> (ø)
...erver/glommio_impl/processor/partition_consumer.rs 61.36% <61.36%> (ø)
src/common/mod.rs 61.90% <61.90%> (ø)
src/commit_log/mod.rs 75.00% <70.00%> (+2.90%) ⬆️
...c/commit_log/glommio_impl/segmented_log/segment.rs 72.72% <72.72%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arindas arindas merged commit dfc2cfa into main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arindas @codecov-commenter