Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage and remove unused modules #6

Merged
merged 9 commits into from
Dec 28, 2022
Merged

Improve code coverage and remove unused modules #6

merged 9 commits into from
Dec 28, 2022

Conversation

arindas
Copy link
Owner

@arindas arindas commented Dec 28, 2022

  • Added tests for single_node router
  • Added tests for PartitionConsumer failure paths
  • Exclude compat modules and Display impls from code coverage
  • Move from BytesCow to Bytes in InMemPartition

@arindas arindas changed the title Improve code coverage Improve code coverage and remove unused modules Dec 28, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 68.89% // Head: 80.30% // Increases project coverage by +11.40% 🎉

Coverage data is based on head (f1ae883) compared to base (ea107ca).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #6       +/-   ##
===========================================
+ Coverage   68.89%   80.30%   +11.40%     
===========================================
  Files          21       18        -3     
  Lines         942      858       -84     
===========================================
+ Hits          649      689       +40     
+ Misses        293      169      -124     
Impacted Files Coverage Δ
src/commit_log/mod.rs 75.00% <ø> (ø)
src/commit_log/segmented_log/mod.rs 79.45% <ø> (+2.38%) ⬆️
src/commit_log/segmented_log/segment.rs 85.55% <ø> (+10.06%) ⬆️
src/common/mod.rs 100.00% <ø> (+38.09%) ⬆️
src/server/glommio_impl/mod.rs 76.92% <ø> (ø)
...erver/glommio_impl/processor/partition_consumer.rs 75.00% <ø> (+13.63%) ⬆️
src/server/glommio_impl/processor/single_node.rs 74.28% <ø> (ø)
src/server/partition/single_node/commit_log.rs 69.76% <ø> (+10.94%) ⬆️
src/server/worker.rs 66.66% <ø> (+19.29%) ⬆️
src/commit_log/glommio_impl/segmented_log/store.rs 77.51% <80.00%> (+0.10%) ⬆️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arindas arindas merged commit a778f81 into main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants