Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prompt passwords from stdin if not provided via CLI options #340

Merged
merged 4 commits into from
Aug 4, 2023
Merged

feat: prompt passwords from stdin if not provided via CLI options #340

merged 4 commits into from
Aug 4, 2023

Conversation

mtache
Copy link
Collaborator

@mtache mtache commented Aug 4, 2023 •
edited
Loading

Use click password_option and prompt to prompt EOS passwords if not provided via environment variables or CLI options.
This is to provide a more secure way to provide passwords without using environment variables.

@mtache mtache requested a review from titom73 August 4, 2023 09:59
titom73
titom73 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@titom73 titom73 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

❯ anta nrfu --catalog .personal/catalog-class.yml table
Please enter a password to connect to EOS: 
Repeat for confirmation: 
...

But password is asked even for --help

❯ anta nrfu --help
Please enter a password to connect to EOS: 
Aborted!

@titom73 titom73 self-requested a review August 4, 2023 11:23
@titom73 titom73 added the Anta CLI All things around CLI label Aug 4, 2023
@titom73 titom73 added this to the v0.8.0 milestone Aug 4, 2023
titom73
titom73 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🐜

@titom73 titom73 merged commit b33924c into aristanetworks:main Aug 4, 2023
17 checks passed
@mtache mtache deleted the prompt-password branch August 4, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

Assignees

@mtache mtache

Labels
Anta CLI All things around CLI rn: feat
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mtache @titom73