Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta.tests): Add support for more options in VerifyL3MTU #345

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

titom73
Copy link
Collaborator

@titom73 titom73 commented Aug 7, 2023

Add support for more options in anta.tests.interfaces.VerifyL3MTU

  • Generic MTU expected on all interfaces
  • A list of specific MTU per interface
  • A list of interfaces to ignore (added to built-in excluded interfaces)

List of excluded interfaces: ["Management", "Loopback", "Vxlan", "Tunnel"]

Input example:

anta.tests.interfaces:
  VerifyL3MTU:
    mtu: 1500
    ignored_interfaces:
      - Management1
      - Vxlan1
    specific_mtu:
      - Ethernet1/1: 1500

Example output:

┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Device IP ┃ Test Name                ┃ Test Status ┃ Message(s)                                          ┃ Test description                                                                    ┃ Test category ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ spine01   │ VerifyZeroTouch          │ success     │                                                     │ Verifies ZeroTouch is disabled.                                                     │ configuration │
│ spine01   │ VerifyRunningConfigDiffs │ success     │                                                     │                                                                                     │ configuration │
│ spine01   │ VerifyL3MTU              │ failure     │ Some interfaces do not have correct MTU configured: │ Verifies the global layer 3 Maximum Transfer Unit (MTU) for all layer 3 interfaces. │ interfaces    │
│           │                          │             │ [{'Ethernet1': 9214}, {'Ethernet6': 9214}]          │                                                                                     │               │
└───────────┴──────────────────────────┴─────────────┴─────────────────────────────────────────────────────┴─────────────────────────────────────────────────────────────────────────────────────┴───────────────┘

@titom73 titom73 added this to the v0.8.0 milestone Aug 7, 2023
@titom73 titom73 self-assigned this Aug 7, 2023
@titom73 titom73 linked an issue Aug 7, 2023 that may be closed by this pull request
anta/tests/interfaces.py Outdated Show resolved Hide resolved
anta/tests/interfaces.py Outdated Show resolved Hide resolved
anta/tests/interfaces.py Outdated Show resolved Hide resolved
anta/tests/interfaces.py Outdated Show resolved Hide resolved
anta/tests/interfaces.py Outdated Show resolved Hide resolved
anta/tests/interfaces.py Outdated Show resolved Hide resolved
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mtache mtache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working with cEOS

@titom73 titom73 merged commit 8990976 into aristanetworks:main Aug 8, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L3MTU test fails for dynamic VLANs
3 participants