Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Exit nicely when runner gets empty list of tests #420

Merged
merged 7 commits into from
Oct 3, 2023

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Sep 29, 2023

Description

cf title

Fixes #419

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

anta/runner.py Outdated Show resolved Hide resolved
\ Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy pasta error?

gmuloc and others added 3 commits October 3, 2023 09:09
Co-authored-by: carl-baillargeon <63206086+carl-baillargeon@users.noreply.github.com>
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally! LGTM

@carl-baillargeon carl-baillargeon merged commit 032ca14 into aristanetworks:main Oct 3, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Have a warning log message when the list of tests is empty
2 participants