Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): Fix VerifyLLDPNeighbors #430

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix(anta.tests): Fix VerifyLLDPNeighbors #430

merged 2 commits into from
Oct 17, 2023

Conversation

carl-baillargeon
Copy link
Contributor

Description

Added a check in VerifyLLDPNeighbors when the interface is not configured on the device. The test will now fail and give a proper message instead of generating a KeyError.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@carl-baillargeon carl-baillargeon changed the title Fix(anta.tests): Fix VerifyLLDPNeighbors fix(anta.tests): Fix VerifyLLDPNeighbors Oct 10, 2023
@gmuloc gmuloc merged commit 0037d27 into aristanetworks:main Oct 17, 2023
18 of 19 checks passed
@gmuloc gmuloc added this to the v0.11.0 milestone Oct 17, 2023
@titom73 titom73 mentioned this pull request Nov 11, 2023
Merged
@carl-baillargeon carl-baillargeon deleted the fix/lldp_neighbors branch May 18, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@mtache mtache Awaiting requested review from mtache

@titom73 titom73 Awaiting requested review from titom73

Assignees

@carl-baillargeon carl-baillargeon

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@carl-baillargeon @gmuloc