Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve various logs #481

Merged
merged 5 commits into from
Nov 24, 2023
Merged

fix: improve various logs #481

merged 5 commits into from
Nov 24, 2023

Conversation

mtache
Copy link
Collaborator

@mtache mtache commented Nov 24, 2023 •
edited
Loading

Description

Fixes #463
Fixes #466

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@mtache mtache requested a review from gmuloc November 24, 2023 12:14
gmuloc
gmuloc reviewed Nov 24, 2023
View reviewed changes
anta/catalog.py Outdated Show resolved Hide resolved
anta/catalog.py Outdated Show resolved Hide resolved
anta/catalog.py Outdated Show resolved Hide resolved
tests/units/test_catalog.py Outdated Show resolved Hide resolved
tests/units/test_catalog.py Outdated Show resolved Hide resolved
tests/units/test_catalog.py Outdated Show resolved Hide resolved
tests/units/test_catalog.py Outdated Show resolved Hide resolved
gmuloc
gmuloc approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: it it passes CI

@gmuloc gmuloc merged commit 9a7816e into aristanetworks:main Nov 24, 2023
19 checks passed
@mtache mtache deleted the issue/466 branch November 24, 2023 15:25
@titom73 titom73 mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

Assignees

@mtache mtache

Labels
rn: fix
Projects
None yet
Milestone
No milestone
2 participants
@mtache @gmuloc