Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anta)!: improve ANTA for high scale NRFU #622

Merged
merged 12 commits into from
Apr 10, 2024

Conversation

mtache
Copy link
Collaborator

@mtache mtache commented Apr 4, 2024

Description

In some environments where the file descriptor limit of the system is the default (1024 per process) and a lot of tests needs to be performed, the Linux system will refuse to allocate more file descriptor to the ANTA process.

Also improve timeout logging and documentation and fixes #487.

Task list

  • Read and print in logs (preferably in DEBUG) the current system ulimit settings
  • Investigate the possibility to limit the number of concurrent co-routines to be less than the file descriptors limits on the system and display a warning if this is the case
  • Document how to tweak Linux hosts to increase the file descriptor limit
  • Improving logging for timeout issues
  • Improve this except block to display catch the nested OSError Exception and display a clear ERROR: https://github.com/arista-netdevops-community/anta/blob/main/anta/device.py#L347

Fixes #618
Fixes #487

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@mtache mtache force-pushed the fix/618 branch 2 times, most recently from f259ca5 to f3b2465 Compare April 8, 2024 15:55
@mtache mtache changed the title feat: improve ANTA for high scale NRFU feat(anta): improve ANTA for high scale NRFU Apr 9, 2024
@gmuloc gmuloc modified the milestones: v1.1.0, v1.0.0 Apr 9, 2024
@mtache mtache requested a review from gmuloc April 9, 2024 16:32
@mtache mtache marked this pull request as ready for review April 9, 2024 16:32
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

anta/device.py Outdated Show resolved Hide resolved
anta/device.py Outdated Show resolved Hide resolved
anta/device.py Outdated Show resolved Hide resolved
anta/device.py Outdated Show resolved Hide resolved
anta/device.py Outdated Show resolved Hide resolved
anta/runner.py Outdated Show resolved Hide resolved
docs/cli/debug.md Show resolved Hide resolved
docs/faq.md Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@gmuloc gmuloc changed the title feat(anta): improve ANTA for high scale NRFU feat(anta)!: improve ANTA for high scale NRFU Apr 10, 2024
anta/device.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@gmuloc gmuloc merged commit 799fd98 into aristanetworks:main Apr 10, 2024
20 checks passed
@mtache mtache deleted the fix/618 branch April 10, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants