-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(anta)!: improve ANTA for high scale NRFU #622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtache
force-pushed
the
fix/618
branch
2 times, most recently
from
April 8, 2024 15:55
f259ca5
to
f3b2465
Compare
mtache
changed the title
feat: improve ANTA for high scale NRFU
feat(anta): improve ANTA for high scale NRFU
Apr 9, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
set the soft open file descriptors limit to the hard limit for the current process
Conflicts have been resolved. A maintainer will review the pull request shortly. |
gmuloc
reviewed
Apr 10, 2024
gmuloc
changed the title
feat(anta): improve ANTA for high scale NRFU
feat(anta)!: improve ANTA for high scale NRFU
Apr 10, 2024
gmuloc
reviewed
Apr 10, 2024
gmuloc
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some environments where the file descriptor limit of the system is the default (1024 per process) and a lot of tests needs to be performed, the Linux system will refuse to allocate more file descriptor to the ANTA process.
Also improve timeout logging and documentation and fixes #487.
Task list
Fixes #618
Fixes #487
Checklist:
pre-commit run
)tox -e testenv
)