Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta.cli): Remove --tags from debug commands #727

Merged
merged 3 commits into from
Aug 30, 2024
Merged

feat(anta.cli): Remove --tags from debug commands #727

merged 3 commits into from
Aug 30, 2024

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Jun 20, 2024 •
edited
Loading

Description

Fixes #584

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@gmuloc gmuloc marked this pull request as ready for review August 1, 2024 08:31
@gmuloc gmuloc added this to the v1.1.0 milestone Aug 1, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

carl-baillargeon
carl-baillargeon approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally.

@carl-baillargeon carl-baillargeon merged commit aa1fde8 into aristanetworks:main Aug 30, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carl-baillargeon carl-baillargeon carl-baillargeon approved these changes

Assignees

@gmuloc gmuloc

Labels
rn: feat(anta.cli)
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Find a way to remove tag option for anta debug commands
2 participants
@gmuloc @carl-baillargeon