-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: New anta_workflow plugin using PyAVD #4196
Draft
carl-baillargeon
wants to merge
6
commits into
aristanetworks:devel
Choose a base branch
from
carl-baillargeon:feat/move_anta_to_pyavd
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feat: New anta_workflow plugin using PyAVD #4196
carl-baillargeon
wants to merge
6
commits into
aristanetworks:devel
from
carl-baillargeon:feat/move_anta_to_pyavd
+1,763
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4196
# Activate the virtual environment
source test-avd-pr-4196/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/carl-baillargeon/avd.git@feat/move_anta_to_pyavd#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/carl-baillargeon/avd.git#/ansible_collections/arista/avd/,feat/move_anta_to_pyavd --force
# Optional: Install AVD examples
cd test-avd-pr-4196
ansible-playbook arista.avd.install_examples |
carl-baillargeon
force-pushed
the
feat/move_anta_to_pyavd
branch
2 times, most recently
from
August 13, 2024 18:18
8853a02
to
da57595
Compare
carl-baillargeon
changed the title
Feat: ANTA Integration to PyAVD
Feat: New anta_workflow plugin and anta_runner role to Ansible AVD collection using PyAVD
Aug 13, 2024
carl-baillargeon
force-pushed
the
feat/move_anta_to_pyavd
branch
from
August 17, 2024 14:59
da57595
to
7b8c139
Compare
Quality Gate passedIssues Measures |
carl-baillargeon
force-pushed
the
feat/move_anta_to_pyavd
branch
from
October 26, 2024 10:54
7b8c139
to
3e78cff
Compare
carl-baillargeon
changed the title
Feat: New anta_workflow plugin and anta_runner role to Ansible AVD collection using PyAVD
Feat: New anta_workflow plugin using PyAVD
Oct 31, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
anta_workflow
Ansible action pluginget_device_anta_catalog
public function in PyAVD to generate the ANTA catalogsget_fabric_data
public function in PyAVD to generate the fabric mappings used to generate the catalogseos_validate_state
generated tests and copy them to PyAVDRelated Issue(s)
Needs:
Component(s) name
PyAVD
Proposed changes
Example playbook:
To-do list
anta.reporter.csv_reporter
andanta.reporter.md_reporter
. We should also be able to filter statuses (from plugin arguments) usingResultManager.filter()
VerifyAVTRole
VerifyMlagStatus
VerifyRoutingProtocolModel
VerifyAPIHttpsSSL
VerifySpecificIPSecConn
VerifyStunClient
VerifyNTP
VerifyReloadCause
validate_state: false
configurationaccepted_pwr_supply_states
is not yet implemented in the AVD structured config schemaaccepted_fan_states
is not yet implemented in the AVD structured config schemaaccepted_xcvr_manufacturers
is not yet implemented in the AVD structured config schemaFabricData
to add DPS mappings (investigate if we can improveFabricData
logic)anta_runner
) that will run the action pluginanta_workflows
- Similar tocv_deploy
&cv_workflows
anta_workflow
plugin documentation underplugins.modules
anta_runner
roleSome tests don't require any inputs, in that case we just update PYAVD_TEST_INDEX
Phase 2: Add all ANTA tests 🥇