Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add permit_response_traffic nat to ip-access-lists #4545

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 3, 2024

Change Summary

Add permit_response_traffic: [ nat ] to ip_access_lists

Related Issue(s)

Fixes #4282

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

as described in the issue

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 3, 2024 12:23
Copy link

github-actions bot commented Oct 3, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4545
# Activate the virtual environment
source test-avd-pr-4545/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/4282#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/4282 --force
# Optional: Install AVD examples
cd test-avd-pr-4545
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 3, 2024
Copy link

sonarcloud bot commented Oct 4, 2024

@ClausHolbechArista ClausHolbechArista requested a review from a team October 4, 2024 14:00
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 4, 2024
@gmuloc gmuloc added this to the v5.0.0 milestone Oct 4, 2024
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc merged commit b965223 into aristanetworks:devel Oct 7, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Add permit response traffic: nat under ip_access_lists
3 participants