Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[barefoot][platform][arista] Add sfp_type to Sfp class objects #28

Closed

Conversation

vboykox
Copy link
Contributor

@vboykox vboykox commented Jul 30, 2020

Fixes:

Traceback (most recent call last):
  File "/usr/bin/xcvrd", line 1208, in <module>
    main()
  File "/usr/bin/xcvrd", line 1205, in main
    xcvrd.run()
  File "/usr/bin/xcvrd", line 1166, in run
    self.init()
  File "/usr/bin/xcvrd", line 1145, in init
    post_port_sfp_dom_info_to_db(is_warm_start, self.stop_event)
  File "/usr/bin/xcvrd", line 432, in post_port_sfp_dom_info_to_db
    post_port_dom_info_to_db(logical_port_name, dom_tbl, stop_event)
  File "/usr/bin/xcvrd", line 357, in post_port_dom_info_to_db
    if platform_chassis.get_sfp(physical_port).sfp_type == 'QSFP_DD':
AttributeError: 'Sfp' object has no attribute 'sfp_type'

Environment
SONiC Software Version: SONiC.HEAD.729-dirty-20200727.195955
Distribution: Debian 10.4
Kernel: 4.19.0-9-2-amd64
Build commit: 89184038

Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
@vboykox vboykox changed the title Add sfp_type to Sfp class objects [barefoot][platform][arista] Add sfp_type to Sfp class objects Jul 30, 2020
@vboykox
Copy link
Contributor Author

vboykox commented Jul 30, 2020

@akokhan

@vboykox
Copy link
Contributor Author

vboykox commented Jul 30, 2020

@tsuna @aaronbee @pooya @peadar

@vboykox
Copy link
Contributor Author

vboykox commented Jul 30, 2020

@Staphylo

@vboykox vboykox force-pushed the bfn_arista_platform_sfp_type branch from f8a055e to a04d67e Compare July 30, 2020 17:19
@Staphylo
Copy link
Member

Thanks for the PR.
It can't merge via github as it has to go through our internal process first.
I'll be back on Tuesday to see to it if @zzhiyuan doesn't cherry-pick it by then.

@Staphylo
Copy link
Member

Staphylo commented Aug 4, 2020

I cherry-picked your change and it's now running some tests. I believe it should go well.
Your change will motivate an upstreaming session in the coming days.
I will resolve/close this issue once it's done.

Arista-Jenkins pushed a commit that referenced this pull request Aug 6, 2020
Authored-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Origin: #28
Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Change-Id: Ie5d5d23d672bc6a3549a554c8b998cf7dea76453
@Staphylo
Copy link
Member

Staphylo commented Aug 6, 2020

Merged via 99e5e07

@Staphylo Staphylo closed this Aug 6, 2020
Arista-Jenkins pushed a commit that referenced this pull request Aug 24, 2023
Authored-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Origin: #28
Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Change-Id: Ie5d5d23d672bc6a3549a554c8b998cf7dea76453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants