Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align get_status_led to expected API #29

Closed
wants to merge 1 commit into from
Closed

Align get_status_led to expected API #29

wants to merge 1 commit into from

Conversation

vboykox
Copy link
Contributor

@vboykox vboykox commented Aug 26, 2020 •
edited
Loading

Signed-off-by: Volodymyr Boyko volodymyrx.boiko@intel.com

The changes are intended to fix the following warnings:

Aug 18 19:23:10.981375 sonic WARNING pmon#psud[37]: Failed to get led status for psu 1
Aug 18 19:23:10.981608 sonic WARNING pmon#psud[37]: Failed to get led status for psu 2
Aug 18 19:23:13.983173 sonic WARNING pmon#psud[37]: Failed to get led status for psu 1
Aug 18 19:23:13.983319 sonic WARNING pmon#psud[37]: Failed to get led status for psu 2

Reproduced on SONiC.HEAD.745-dirty-20200818.151309

@vboykox
Align get_status_led to expected API
1104b98 
Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
@Staphylo
Copy link
Member

Staphylo commented Aug 26, 2020 •
edited
Loading

Thanks for your contribution, change LGTM.
I'll be cherry-picking your change and making it go through our internal process.

Arista-Jenkins pushed a commit that referenced this pull request Sep 1, 2020
@vboykox @Staphylo
Align get_status_led to expected API
94fd519 
Authored-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Origin: #29
Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Change-Id: I6aec24bb9d9bbbd8389e2e73984cc172346405f2
@Staphylo
Copy link
Member

Staphylo commented Sep 1, 2020

I will be make a PR to https://github.com/Azure/sonic-buildimage/tree/master/ to update the submodules with your fix.
This time I figured out a way to preserve the original Author name :)

@Staphylo Staphylo closed this Sep 1, 2020
@vboykox
Copy link
Contributor Author

vboykox commented Sep 2, 2020

I will be make a PR to https://github.com/Azure/sonic-buildimage/tree/master/ to update the submodules with your fix.
This time I figured out a way to preserve the original Author name :)

Thanks!

@vboykox
Copy link
Contributor Author

vboykox commented Sep 7, 2020

Hi!
When can we expect SONiC submodule to be updated?

@Staphylo
Copy link
Member

Staphylo commented Sep 8, 2020

Hi Volodymyr,

The PR has been merge ready for a week. I'm waiting for msft to pick it up sonic-net/sonic-buildimage#5296
The engineer that usually takes care of it should be back from vacation this week so probably not much longer.

Arista-Jenkins pushed a commit that referenced this pull request Aug 24, 2023
@vboykox @Arista-Jenkins
Align get_status_led to expected API
4e05fa0 
Authored-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Origin: #29
Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Change-Id: I6aec24bb9d9bbbd8389e2e73984cc172346405f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vboykox @Staphylo