Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Add graphic protocol support #30

Closed
WSLUser opened this issue Sep 23, 2021 · 1 comment
Closed

[REQUEST] Add graphic protocol support #30

WSLUser opened this issue Sep 23, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@WSLUser
Copy link

WSLUser commented Sep 23, 2021

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Add support for Sixel, Kitty, and Iterm2's graphic protocols. Take a look at https://github.com/hackerb9/lsix for example (which just does Sixel).
Describe the solution you'd like
A clear and concise description of what you want to happen.
Add support for the graphic protocols in order to improve graphics further, and in some cases potentially boost performance as well. On Linux, start with detecting Kitty support. Kitty and Wezterm both support the Kitty protocol and notcurses favors this support when available, otherwise detect Sixel. Otherwise ignore altogether. On Mac, look for Iterm2 graphics protocol support (assuming you're not running on the aforementioned terminals), if it's not there, then search for Sixel and if that's not available, ignore there too.

Notcurses also has a fall-back layer where graphics protocols aren't supported, it will display things as best it can, which is still pretty well, if not quite as good which can make notcurses an optional dependency of this feature request (you may need to do very little as notcurses does detection for all 3 protocols).
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Do nothing.
Additional context
Add any other context or screenshots about the feature request here.

@WSLUser WSLUser added the enhancement New feature or request label Sep 23, 2021
@aristocratos
Copy link
Owner

@WSLUser
If you're gonna suggest random libraries that comes to your mind you should maybe look in to what btop++ aims to do and have a look at the code.

I can see no need for "graphic protocol support".

If you do, maybe mention how and to what end instead of linking to unrelated software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants