Rewrite original code #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace `Section`'s generics with an enum field.
Selecting Sections is not really useful yet, it will only be the case when dealing with the filter/finder for subsets of size 1.
- Made the crate root be the sudoku `Solver` trait along with the `Board` abstraction. - Moved all the existing code into `solvers/psr/`. Also added `solvers/btr/` for my backtracking solution. - All of a `Solver`s core definitions and implementations lie in their `core` submodule.
Renamed `Cell::set_known` to `Cell::set_known_bit` to better convey the function's functionality
`CellMask::new` now returns `None` if the passed `u16` does not conform to the required representation.
Refactor `0b000000_111_111_111_0` into its own `const` variable for better ergonomics and intent across modules.
Removed the leading `000000_` in `const u16` expressions for greater conciseness in settings where it is assumed that the banned bits are zero. Kept the old byte grouping in cases where the banned bits are part of the context.
Improved docs for `CellMask`
Rewrote original implementation for `Lines` (now `FoldedArea`). Implementation is still in early stages of development, likely requires further rewriting.
|
Force the merge instead of going through conflicts in the pull request. |
|
Try again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed the rewrite of the original code written at the inception of the project.
Rewritten implementation contains more robust, clear, and performant code, as well as being better documented. Status still remains in early development.