This repository has been archived by the owner on May 30, 2023. It is now read-only.
Ghostdriver Development Branch: pull request #2 #293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't need a reference to the Config object (for now).
This addresses [Issue #151](http://code.google.com/p/phantomjs/issues/detail?id=151). Summary of the new API: - page.pages[] - page.pagesWindowName[] - page.getPage(windowName) - page.windowName - page.onPageCreated = function(newPage) { ... } The page object created by the user holds responsibility of the "child" pages it creates. If a page closes (i.e. window.close()) or a call to "page.pages[i].release()" is done, the array "page.pages[]" will automatically update to contain only the pages still open.
This addresses issue [#654](http://code.google.com/p/phantomjs/issues/detail?id=654).
|
Half-way testing and merged. |
|
Why half way? ;) Ivan De Marino Sent while standing on one leg On 13 Jul 2012, at 18:00, Ariya Hidayat
|
|
Because time is not always in your favor. |
|
Oh, I didn't mean in "that" way. Ivan De Marino Sent while standing on one leg On 13 Jul 2012, at 23:53, Ariya Hidayat
|
|
Nothing particular, I just had to stop midway due to some other commitment. |
|
Merged. Thanks! |
This was referenced Mar 15, 2013
detro
added a commit
that referenced
this pull request
Jan 5, 2014
CHANGELOG for v1.1.0 (https://github.com/detro/ghostdriver/issues?labels=1.1.0&state=closed) JavaScript Driver (Core) * ENHANCEMENT: `/maximize` window will set the window size to 1336x768, currently most common resolution online (see http://gs.statcounter.com/#resolution-ww-monthly-201307-201312) * ENHANCEMENT #275: Implemented Browser and Network (HAR) Logging types * FIXED #284: Attempt to wait for Page to Load if input causes form submit * FIXED #291: Throw exception when attempting to set invalid timeout value * FIXED #259: Fix issue regarding mouse clicks * ENHANCEMENT #290: Enabled support for "Keep Alive" HTTP connections * ENHANCEMENT #262: Allow access to PhantomJS API from WebDriver (Driver part) * ENHANCEMENT #293: Import Selenium 2.39.0 WebDriver Atoms Java Binding * MINOR #251: Minor compilation issues for Binding * ENHANCEMENT #262: Allow access to PhantomJS API from WebDriver (Java Binding part) Tested using GhostDriver validation tests (https://github.com/detro/ghostdriver/tree/master/test). #11877
detro
added a commit
that referenced
this pull request
Jan 19, 2014
CHANGELOG for v1.1.0 (https://github.com/detro/ghostdriver/issues?labels=1.1.0&state=closed) JavaScript Driver (Core) * ENHANCEMENT: `/maximize` window will set the window size to 1336x768, currently most common resolution online (see http://gs.statcounter.com/#resolution-ww-monthly-201307-201312) * ENHANCEMENT #275: Implemented Browser and Network (HAR) Logging types * FIXED #284: Attempt to wait for Page to Load if input causes form submit * FIXED #291: Throw exception when attempting to set invalid timeout value * FIXED #259: Fix issue regarding mouse clicks * ENHANCEMENT #290: Enabled support for "Keep Alive" HTTP connections * ENHANCEMENT #262: Allow access to PhantomJS API from WebDriver (Driver part) * ENHANCEMENT #293: Import Selenium 2.39.0 WebDriver Atoms Java Binding * MINOR #251: Minor compilation issues for Binding * ENHANCEMENT #262: Allow access to PhantomJS API from WebDriver (Java Binding part) Tested using GhostDriver validation tests (https://github.com/detro/ghostdriver/tree/master/test). #11877
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this pull request covers 2 Issues that are "dear" to the GhostDriver project (it can't procede without this actually).
Also, 2/3 minor commits to fix little details around our code base (tiny but annoying stuff).
As usual, everything comes with tests.