Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make embedded btc wallet produce less logs #333

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

altafan
Copy link
Collaborator

@altafan altafan commented Sep 26, 2024

There's no way to change the level of the logs a service produces. Rather, we can set the the min log level for it and make those of the levels above disappear.

This makes the embedded btc wallet produce fewer logs by setting the log level of all components to warning.

NOTE: There's no way to set a log level for the sqlite db we use currently modernc.org/sqlite. Maybe we should move to something else? Is there a specific reason we chose this one? @louisinger @tiero

Closes #287

Please @louisinger @tiero review

@tiero
Copy link
Member

tiero commented Sep 26, 2024

It's the only go native so no CGO

@tiero
Copy link
Member

tiero commented Sep 26, 2024

Something even lower than warn? Like debug or trace?

@altafan
Copy link
Collaborator Author

altafan commented Sep 26, 2024

These are the levels. If we set Trace log level, it means we want to see the logs of all levels, if we use Debug we exclude only trace logs and so on. We use Warn to see only warning errors and criticals and exclude all the other levels.

@altafan altafan merged commit 7676b3d into ark-network:master Sep 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arkd: less important logs should be log level debug
2 participants