Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make package compatible with Laravel 11 #180

Merged
merged 16 commits into from
Apr 16, 2024

Conversation

arkaitzgarro
Copy link
Owner

@arkaitzgarro arkaitzgarro commented Mar 21, 2024

Based on #179 but with PHP 8.2 fixes.

Closes #179

@countless-integers
Copy link
Collaborator

tests/unit/Collectors/JobCollectorTest.php:testJobProcessingListenerIgnored is failing and looks like it might need some looking into.

Base automatically changed from chore/enable-php-8.2 to master March 21, 2024 13:07
@@ -107,6 +107,12 @@ public function testJobProcessingListenerIgnored()
$this->agentMock->shouldNotReceive('startTransaction');
$this->agentMock->shouldNotReceive('getTransaction');

// For Laravel 11+
if (class_exists('\Illuminate\Support\Facades\Context')) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, that's a new thing in L11.

@arkaitzgarro arkaitzgarro merged commit fd81143 into master Apr 16, 2024
24 checks passed
@arkaitzgarro arkaitzgarro deleted the chore/laravel11-compatibility branch April 16, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants