Reset EventDataCollectors and add Metadata after each send #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstepe
force-pushed
the
chore/handle-events-in-long-processes
branch
from
3978f0f
to
76842a6
Compare
| @@ -136,4 +136,10 @@ private function toMilliseconds(float $time): float | |||
| { | |||
| return round($time * 1000, 3); | |||
| } | |||
|
|
|||
| public function reset(): void | |||
There was a problem hiding this comment.
Could you add this method to the AG\ElasticApmLaravel\Contracts\DataCollector interface?
There was a problem hiding this comment.
Done. Waiting on the checks to confirm. I rebased and squashed the commits to clean this up as well.
dstepe
force-pushed
the
chore/handle-events-in-long-processes
branch
from
5451d87
to
3763ee3
Compare
The old package does not include the metadata argument.
|
@dstepe This fix was perfect, I really appreciate you handling it so quickly. 🎉 |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57
The current event collection results in problems with long running worker processes. The required metadata is not being added before each batch and the event collectors are not being cleared after sending. Overriding the base
Agent::send()allows us to work around both issues as a short term fix. The baseAgentpackage will improve the event collection process in a future release to address this. You may want to look into a better way to reset the collectors in this package.I have tested this on my reference application with a worker queue and it appears to work as expected. However, I do not have the philkra agent package installed and cannot attest to this being fully ready to merge. I offer is a starting point for addressing the reported issue.