Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner not updating with TypeScript LSP #15

Open
icholy opened this issue Jan 16, 2022 · 12 comments
Open

Spinner not updating with TypeScript LSP #15

icholy opened this issue Jan 16, 2022 · 12 comments

Comments

@icholy
Copy link

icholy commented Jan 16, 2022

The spinner doesn't update when using typescript-language-server.

tty

The LSP doesn't send $/progress reports aside from begin and end (because the underlying tsserver doesn't support them). I proposed sending fake progress reports, but that wasn't accepted. typescript-language-server/typescript-language-server#373

Is there a way to work around this?

@BobbyGerace
Copy link

I had this issue as well. Here is a pull request with a fix #20

@rockyzhang24
Copy link

The spinner works well in ts file now. Probably some updates on upstream made this issue fixed.

@icholy
Copy link
Author

icholy commented May 16, 2022

@rockyzhang24
Copy link

@icholy Yes it works and updates as expected on my side.

@icholy
Copy link
Author

icholy commented May 16, 2022

@rockyzhang24 which versions of neovim, lualine-lsp-progress, and typescript-langauge-server do you have installed?

@rockyzhang24
Copy link

rockyzhang24 commented May 16, 2022

@icholy
neovim version: NVIM v0.8.0-dev+1660-g9e4286294 (the nightly)
lua-lsp-progress: normally installed and the latest commit
typescript-language-server: 0.10.0, the latest

I cloned a large repo supabase to make the progress noticeable.

Screen.Recording.2022-05-16.at.07.22.26.mov

@icholy
Copy link
Author

icholy commented May 16, 2022

@rockyzhang24 those are the begin / end progress notifications coming through. If you open a larger project (on a slower computer), you'll notice that it's not updating correctly. Your computer is loading the project so quickly that you're not seeing the issue.

@rockyzhang24
Copy link

Not really. They are not just begin and end progress. See the screenshot below.

1

2

3

Both the first two pics are in the "progress" step. Thanks.

@icholy
Copy link
Author

icholy commented May 16, 2022

I just checked mine again and I am getting 1 update while (In Progress). Again, if you manage to find a project that takes more than a few seconds to load, you will see the issue.

@rockyzhang24
Copy link

rockyzhang24 commented May 16, 2022

@icholy Let me find a large project and try it again.

Update:
Yes, you're right. I tested again in a large ts repo and the spinner was stuck after one update while (In Progress) until (Completed).

@arkav Could you please merge the PR to fix this issue? Thanks a lot.

@icholy
Copy link
Author

icholy commented May 16, 2022

@rockyzhang24 out of curiosity, what kind of machine (specs) are you running on?

@rockyzhang24
Copy link

@icholy 16 inch MacBook Pro with M1 Pro, 32GB Memory + 1TB SSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants