App の initializer, entry_point の返り値を void から RESULT にする #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ToshiAki64 別の機能実装中に欲しくなったので機能追加してます． レビュー後に，OKそうであれば，既存の App の関数の型を直していきます． |
meltingrabbit
changed the title
|
@ToshiAki64 ありがとうございます． |
meltingrabbit
force-pushed
the
feature/fix_url_of_docs
branch
from
f01ed71
to
14ac9b6
Compare
meltingrabbit
force-pushed
the
feature/change_ret_type_of_app_initializer
branch
from
6521bc2
to
8164836
Compare
Closed
sksat
added a commit
that referenced
this pull request
Oct 17, 2023
sksat
added a commit
that referenced
this pull request
Oct 27, 2023
sksat
added a commit
that referenced
this pull request
Oct 30, 2023
sksat
added a commit
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
App の initializer, entry_point の返り値を void から RESULT にする
Issue
詳細
App の初期化，実行のエラーをAMに通知する方法を追加
検証結果
全てのテストが通った
影響範囲
user の App の initializer, entry_point を修正する必要がある
補足