-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply rename migration to example users: Script -> script #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
手元で確認してないんだけども,git revision 埋め込みとかも動いてるよね?(壊れる可能性あるよなぁとおもったけど,CI通ってれば大丈夫か?) |
今は CMake から明示的に呼び出してて,動いてなかったらビルドコケるんで大丈夫です > git revision 埋め込み |
meltingrabbit
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
おつかれ
Base automatically changed from
feature/rename-script-dir-to-snake-case
to
develop
August 2, 2023 08:58
あれ,conflict した |
subobc やり直し |
sksat
force-pushed
the
feature/rename-script-examples
branch
from
August 2, 2023 09:02
8100720
to
e49c0d7
Compare
sksat
force-pushed
the
feature/rename-script-examples
branch
from
August 2, 2023 09:05
e49c0d7
to
ca5aede
Compare
rebase してやり直した |
CI 通ったのでマージ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
Script -> script への migration を Example user に適用した
Issue / PR