-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename TlmCmd dir to snake case #79
Conversation
…gs/tlm_cmd/ccsds)
0da429b
to
2e75f76
Compare
…st/test/src_core/tlm_cmd)
あ~,これ https://github.com/ut-issl/c2a-tlm-cmd-code-generator に依存ある. enum loaderと同じ対応?(そして,こちらに修正あるとpre release必要?) |
あーそうか......一旦 enum loader と同じく v4 branch 切ってそれで対応ですかね |
v3, v4 以降 の両メンテは厳しいと思う + enum loader と同じく c2a-core に吸収したい(リリース単位が本来同じはず)ので,ut-issl org 側のリポジトリでのリリースは一旦考えなくてよいと思います. |
OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良いのではなかろうか
c2a-tlm-cmd-generator は一旦 ae-v4 branch で対応.以下の設定でコード生成して, #80 で diff が出なかったので OK
{
"path_to_src" : "c2a-core/examples/mobc/src/",
"path_to_db" : "c2a-core/examples/mobc/src/src_user/Settings/tlm_cmd/data_base/",
"db_prefix" : "SAMPLE_MOBC",
"tlm_id_range" : ["0x00", "0x100"],
"is_cmd_prefixed_in_db" : 0,
"input_file_encoding" : "utf-8",
"output_file_encoding" : "utf-8",
"is_main_obc" : 1,
"other_obc_data" : [
{
"name" : "AOBC",
"is_enable" : 1,
"db_prefix" : "SAMPLE_AOBC",
"tlm_id_range" : ["0x90", "0xc0"],
"is_cmd_prefixed_in_db" : 0,
"input_file_encoding" : "utf-8",
"path_to_db" : "c2a-core/examples/subobc/src/src_user/Settings/tlm_cmd/data_base/",
"max_tlm_num" : 256,
"driver_path" : "Aocs/",
"driver_type" : "AOBC_Driver",
"driver_name" : "aobc_driver",
"code_when_tlm_not_found" : "aobc_driver->info.comm.rx_err_code = AOBC_RX_ERR_CODE_TLM_NOT_FOUND;"
}
]
}
{
"path_to_src" : "c2a-core/examples/subobc/src/",
"path_to_db" : "c2a-core/examples/subobc/src/src_user/Settings/tlm_cmd/data_base/",
"db_prefix" : "SAMPLE_AOBC",
"tlm_id_range" : ["0x00", "0x100"],
"is_cmd_prefixed_in_db" : 0,
"input_file_encoding" : "utf-8",
"output_file_encoding" : "utf-8",
"is_main_obc" : 0
} |
問題ないと思われるのでマージ |
概要
TlmCmd
以下のディレクトリを snake_case にするsrc_user/Settings/TlmCmd
以下のディレクトリも snake_case にするsrc_user/Settings/TlmCmd/DataBase/*
については,別途場所の変更・標準化をしたいのと,そもそも既存の命名が命名規則に違反しているので一旦取り扱わないIssue