Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Select component #49

Merged
merged 11 commits into from
Jul 25, 2023
Merged

feat: add Select component #49

merged 11 commits into from
Jul 25, 2023

Conversation

ilyichv
Copy link
Member

@ilyichv ilyichv commented Jul 22, 2023

Description

As per title

Related Issue

Fixes #45

Test

  • I have added tests that prove my fix is effective or that my feature works

@ilyichv ilyichv requested a review from a team as a code owner July 22, 2023 23:42
@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2023

🦋 Changeset detected

Latest commit: 1832c26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@arkejs/ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ilyichv ilyichv added the Don't Merge! Don't merge this PR label Jul 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #49 (69589f0) into refactor/remove-css (1bf51c2) will decrease coverage by 9.27%.
The diff coverage is 66.80%.

@@                   Coverage Diff                   @@
##           refactor/remove-css      #49      +/-   ##
=======================================================
- Coverage                95.32%   86.06%   -9.27%     
=======================================================
  Files                       44       49       +5     
  Lines                      535      739     +204     
  Branches                   219      275      +56     
=======================================================
+ Hits                       510      636     +126     
- Misses                      24       97      +73     
- Partials                     1        6       +5     

Impacted file tree graph

@ilyichv ilyichv changed the base branch from main to refactor/remove-css July 25, 2023 13:07
@ilyichv ilyichv removed the Don't Merge! Don't merge this PR label Jul 25, 2023
@ilyichv ilyichv merged commit a6febe6 into refactor/remove-css Jul 25, 2023
@ilyichv ilyichv deleted the feat/select branch July 25, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] - replace @headless/ui select with radix-ui primitive
3 participants