Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css fix: remove tab bullets in FF, make content move down for different widths #34

Merged
merged 1 commit into from
Jul 16, 2015

Conversation

hasMichaels
Copy link

  • Added @media tags as tab content didn't move down for different widths which resulted in breaking the developer experience when completing KOANs or when debugging with debugger on right.
  • Added list-style-none for the tabs, as Firefox added bullets for the tabs
    Tested: Chrome,FF

… well to different media widths (media widths added)
@hasMichaels
Copy link
Author

To test CSS media widths:

  • npm run install; npm run setup; npm run start
  • open up local client in chrome or FF (http://localhost:8080)
  • resize browser from 2556px width -> 400px width and notice that during the resize the tab content remains beneath the tabs

To test FF bullet points are removed from tabs:

  • npm run install; npm run setup; npm run start
  • open up local client in firefox (http://localhost:8080)
  • notice that tabs do not have a list element bullet in front of them
  • resize browser from 2556px width -> 400px width and notice that tabs do not have a list element bullet in front of them

@voter101
Copy link
Contributor

👍 merging.

Thanks for the contribution! :)

Have a nice day.

voter101 added a commit that referenced this pull request Jul 16, 2015
css fix: remove tab bullets in FF, make content move down for different widths
@voter101 voter101 merged commit c0acca1 into arkency:master Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants