Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 0803: browser.urlbar.trimURLs ? #1473

Closed
Thorin-Oakenpants opened this issue Jun 12, 2022 · 4 comments
Closed

remove 0803: browser.urlbar.trimURLs ? #1473

Thorin-Oakenpants opened this issue Jun 12, 2022 · 4 comments

Comments

@Thorin-Oakenpants
Copy link
Contributor

https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarResult.jsm#241

Is it just me, or does 0803 not do anything

/* 0803: display all parts of the url in the location bar ***/
user_pref("browser.urlbar.trimURLs", false);

I've even tested FF60, seems to do jack shit

@rusty-snake
Copy link
Contributor

WFM.

Note: You need a http site to test this. (e.g. http://neverssl.de/)

@Thorin-Oakenpants
Copy link
Contributor Author

right, it's only for HTTP: so here's ESR91

tests

notes

  • it doesn't seem to affect www at all?
  • when it hides http:// clicking into the urlbar doesn't expand to the untrimmed url (I thought it did in the past?, who cares)
  • copying the URL retains the scheme

We already have HTTPS-Only mode which causes an interstitial (excluding site exceptions), and a red padlock is shown if you do go there, plus I guess you could say the lack of the scheme is also a sign

Pretty much going to say this pref is redundant and we can remove it. All in favor of the MIGHTY PANTS, say Aye

Thorin-Oakenpants added a commit that referenced this issue Jun 12, 2022
one less pref, which is pretty much just a cosmetic feel good factor
Thorin-Oakenpants added a commit that referenced this issue Jun 12, 2022
@fxbrit
Copy link
Collaborator

fxbrit commented Aug 5, 2023

@Thorin-Oakenpants
Copy link
Contributor Author

AF is almost always ahead of the curve - moz just need to move slow and not break things, and priorities - but that entirely misses the point that 1846646 is only an android change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants