Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few things to reconsider #237

Closed
6 tasks done
earthlng opened this issue Sep 15, 2017 · 9 comments
Closed
6 tasks done

a few things to reconsider #237

earthlng opened this issue Sep 15, 2017 · 9 comments

Comments

@earthlng
Copy link
Contributor

earthlng commented Sep 15, 2017

  • 1261, 1262 + 1263 - IMO we should comment these out by default.
    Even if someone never allows JS and therefore eliminates most FP vectors, these prefs still puts them in a very small group. Not even the Tor guys disable those in TBB even though they could do it without increasing their users uniqueness. Not worth it IMO. - 89474d0

  • 2500: things that are not necessary to disable if one doesn't have the hardware for it, fe.

    • 2501 - gamepads
    • 2504 - VR
    • 2509 - touch support
    • 2512 - devices with sensors
    • 2513 - presentation API (added by Thorin)

IMO we should makes those inactive by default. EDIT: done => 598ee75 & 3959462 (thanks Pants)

  • rename ghacks_user.js.parrot to _user.js.parrot to make it the first pref in about:config - bdf0e5e

  • 2024 MSE (Media Source Extensions) => inactive and moved to 5000s - a93ce5d

  • 1404: set legible fonts - move to 1402, shove the others down, make inactive as it affects OS' differently - 80ac9df

  • 2804: clarify Clear Recent History - 7fa0025

@earthlng
Copy link
Contributor Author

These do tighten leaks

what does it leak when I don't have the hardware? Lots of people don't have that hardware but very few people have those APIs disabled.

@earthlng
Copy link
Contributor Author

So what should we do? ...

Yes that's what I would do. VR is default false in ESR52 anyway but we can add a warning regardless.

@earthlng
Copy link
Contributor Author

earthlng commented Sep 15, 2017

Should we really change it this late in the game?

IMO it's more useful if you can see it right away. I would also make the last one a bit clearer, and if you want to make it really cute it's also possible to use unicode fe for the last one:
user_pref("_user.js.parrot", "\u2713 All good! The parrot survived");

\u2713 = ✓
\u2460\u2461\u2778\u2779 = ①②❸❹

@earthlng
Copy link
Contributor Author

earthlng commented Sep 15, 2017

How about

yeah whatever. nerd! ;) Should 9999 also get a parrot?

@earthlng
Copy link
Contributor Author

It was just something to consider. If you don't want to do it that's fine.

@earthlng
Copy link
Contributor Author

Yeah, I suck at crypto too but if not even the TBB guys disable these then I don't think we need to either.

@earthlng
Copy link
Contributor Author

a few more things I noticed while updating my user.js:

  • 1404 - these fonts are Windows-only. I think they are mostly only useful if 1401 is used, right?
    Maybe consider moving 1404 to 1401b, commenting the prefs out and instead of using actual font names that are Windows-only use "your-chosen-font-name-here" or something like that.
    But there's also the problem for Russians for example because they will probably also want to change font.name.serif.x-cyrillic - so maybe it would be better not to include the prefs at all (?).
    Or maybe just get rid of 1404 and add a [NOTE] to 1401 fe.
    [NOTE] you can set more legible default fonts in Options>Fonts & Colors>Advanced>Serif|Sans-serif|Monospace
    maybe with an additional note if you want:
    [NOTE] Georgia or Constantia are pretty nice 'serif' alternatives on Windows for example

  • 2024 - do we really need these? if you want to keep them how about setting them to false and inactive? and/or move them to 5000 where the other media prefs are, idk.

  • 4700 - we once had this [TEST] http://browserspy.dk/showprop.php?navigator, which was pretty useful IMO

  • 2804: set what history items to clear with Ctrl-Shift-Del (to match above)

    • it doesn't clear it though, it only auto-selects them ...
      "auto selection of items to delete with Ctrl-Shift-Del (to match above)" or so would be more accurate

@earthlng
Copy link
Contributor Author

earthlng commented Sep 18, 2017

I was going to do one because everything we want is spread over about 5 test pages and even then it's lacking. Maybe you could code one up some day

https://browserleaks.com/javascript offers exactly what you want, on a single page, no? yeah it misses the INTL.DateFormat stuff but other than that is there anything else missing you would want?

I don't get your point with 2804

my point is that "set" sounds like everything you don't "set" there cannot be cleared/deleted, but all it does is pre-select the items to clear. Nvm the clear vs delete, that was just because I copy-pasted it from my user.js. IDC if it's clear or delete. If you like "set" better then something like "set what items are pre-selected to clear with Ctrl-Shift-Del" would still be easier to understand IMO.

Thorin-Oakenpants added a commit that referenced this issue Sep 18, 2017
Inactive as this actually can cause problems on Linux with tofu (I think arial on debian causes tofu - ask nodiscc) . Also incomplete with non-Western settings
@earthlng
Copy link
Contributor Author

great, thanks for all the commits. You're so receptive recently, no arguing at all, what happened? are you okay? xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants