-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TPM configuration #50
base: main
Are you sure you want to change the base?
Conversation
Hi @jcf. Thanks for your pull-request. |
This is an interesting idea, even though we just added homebrew support I could see tpm support making more sense for this project, but the binary would need to be included in version control :( So far, I think homebrew is a great solution and easy to work with. |
CONFIG="$CURRENT_DIR/gitmux.conf" | ||
|
||
if [ ! -f "$BINARY" ]; then | ||
tmux split-window "cd $CURRENT_DIR && go build -o gitmux && echo 'Press any key to continue...' && read -k1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to support rebuilding the binary when the plugin is updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe best would be to not require the user to have the go toolchain, but automatically download the binary release for their arch/os.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, tpm just pulls from git when doing an update. I looked through the docs some and don't see a concept of an update hook for us to leverage.
It seems like this may be more complicated than it appears. Look out for scope creep.
Purpose
Add TPM configuration to make installation easier.
Approach
Compile
gitmux
automatically, if the binary isn't in the plugin directory, and generate the default configuration.You can use something like this in your Tmux configuration:
If
gitmux
works without a configuration file, you could skip generating the config file, and that would simplify thestatus-right
option.I'm not sure if this is something you want to merge based on #2, but I thought I'd share for anyone else who wants to run this awesome project alongside TPM.
All the best!