Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving default basepath to var, convenience functions to change/creat… #16

Closed
wants to merge 1 commit into from

Conversation

fredim
Copy link

@fredim fredim commented Oct 14, 2020

…e index

hey - love the project. so, my own server has quite an extensive list of handlers, and I just want to put this under a deeper directory structure. actually, I just needed the NewIndex function, but i added the RootDir stuff in case it was useful.

@arl
Copy link
Owner

arl commented Oct 14, 2020

First of all thank you for your interest in the project and for that pull-request.
Also I think that's a great addition

There are some new statsviz features in the making which are going to require some additional configuration, and I think being able to change the root will fit nicely into the API I have in mind.

Once I'll have commited the new API, I'd be delighted to integrate your PR.
I'll tag you here once it's done so you can adapt the code to the new API.

How does that sound?

@arl
Copy link
Owner

arl commented Oct 25, 2020

@fredim
I have just merged the feature I was talking about.
You can now change the root by calling Register(mux, Root("/your/new/root").

@arl
Copy link
Owner

arl commented Oct 25, 2020

So i'm closing since the feature provided by this PR exists already.

@arl arl closed this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants