Functional options api #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Race detector triggers in parallel tests since the websocket upgrader was shared between handlers running concurrently. The upgrader is now local to the websocket handler, that removes the race and is also much cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve public API, which remains 100% compatible, by adding functional options to Register.
At the moment, options are:
Root(root string)-> allow to change handler root (for example to have statsviz athttp://host:port/my/special/statsviz/pathrather than/debug/statsvizSendFrequency(freq time.Duration)-> allow to specify a different frequency for sending the runtime stats from the application to the user interface (default is 1s). Note that at the moment the user interface keeps track of 60 points, whatever is the frequency.Improve code organization.
Add handler tests
Fix a data race (appearing in parallel tests). On non-test code, you would have had to register handlers twice to see that. Anyway it's fixed