Allow ncp filter option #12
Conversation
index.js
Outdated
| @@ -140,7 +144,7 @@ function copyNodeModules(srcDir, dstDir, opts, callback) | |||
|
|
|||
| if (!callback) | |||
| { | |||
| g_opts = {srcDir: srcDir, dstDir: dstDir, devDependencies: false}; | |||
| g_opts = {srcDir: srcDir, dstDir: dstDir, devDependencies: false, filter: null}; | |||
There was a problem hiding this comment.
Probably, you don't need to set filter option to null by default as it's already undefined.
There was a problem hiding this comment.
@SirMomster, thank you for your pull request, nice addition!
But I have some proposals:
-
ncpalso supportsfilteroption through CLI. It would be nice to have this option in CLI ofcopy-node-modulestoo. Can you add it? -
filteroption should be described inREADME.mdfor both programmatic and command line usage to let other people know about it. It would be also nice to mention it in JSDoc ofcopyNodeModulesfunction.
Thanks.
|
@ezze Thanks, I'm glad that I can help, this is my first pull request and your response broke the ice for me. I added support for the CLI it allows Regular Expressions now. But in ncp they match the folder path before matching files. I thought this was important to know so I added it to the readme.md. I totally forgot to do the documentation, sorry for that. But I did it now, I added an example function for a filter method, the JSDoc option and documentation for the CLI. If something is wrong let me know and I will fix it. Fyi. I use your module for a Lerna, typescript project with AWS Lambda, copying node_modules that where "linked" included there dependencies, which I at first removed afterwards but this took a lot of time. Which resulted in this pull request. Thanks for the plugin, it is a great addition to my setup! Saving me about 30-60 mins a day. |
|
Thanks for your help, I'll merge this pull and publish a new version. |
Small changes that would allow usage of the ncp filter option when using copy-node-modules programatically.