Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][v0.3] Fix profile delete bug #231

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

ShaunakJoshi1407
Copy link
Member

@ShaunakJoshi1407 ShaunakJoshi1407 commented Sep 20, 2022

Backport of #196 to v0.3 branch

Aha! Link: https://pf9.aha.io/features/ARLON-306

* attempt delete bugfix

* attempt delete bugfix

* remove commented

* review comment

* review comments

* review comments
@cruizen cruizen self-requested a review September 20, 2022 10:08
@cruizen
Copy link
Member

cruizen commented Sep 20, 2022

@ShaunakJoshi1407 We have only legacy profiles on v0.3 right? Is this backport really required on v0.3 branch?
It is required since we saw that the profiles appear in get profiles -n arlon : So profiles is a CRD in v0.3 too.

@ShaunakJoshi1407 ShaunakJoshi1407 merged commit e653d7b into v0.3 Sep 20, 2022
@Rohitrajak1807 Rohitrajak1807 deleted the private/shaunak/v0.3/fixProfileDelete branch September 20, 2022 11:42
@cre8minus1 cre8minus1 added this to the Not Planned milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants