Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit compile error when no runtime feature specified #282

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

mzeitlin11
Copy link
Collaborator

Inspired by an error I saw when using https://github.com/launchbadge/sqlx. Hopefully gives a bit quicker feedback about how to solve an otherwise giant compilation error when forgetting to specify a runtime feature, though could still be improved as mentioned in the comment.

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Merging #282 (af1aef5) into master (9da5cd9) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #282   +/-   ##
======================================
  Coverage    5.36%   5.36%           
======================================
  Files         150     150           
  Lines       14526   14526           
======================================
  Hits          780     780           
  Misses      13746   13746           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arlyon
Copy link
Owner

arlyon commented Oct 29, 2022

Lovely, TY! I have a PR to fix a longstanding bug #246 which I will request your feedback on if you'd like. I know I said we should sync real quick and talk about plans (since you've decided to stick around! :) ) so if you want to you can book a slot here

https://usemotion.com/meet/alexander-lyon/meeting

Merging!

@arlyon arlyon merged commit 4c58320 into arlyon:master Oct 29, 2022
@mzeitlin11
Copy link
Collaborator Author

Lovely, TY! I have a PR to fix a longstanding bug #246 which I will request your feedback on if you'd like. I know I said we should sync real quick and talk about plans (since you've decided to stick around! :) ) so if you want to you can book a slot here

Thanks, will book one! (Though please don't have too high hopes time I can spend on this tends to be inconsistent :))

@mzeitlin11 mzeitlin11 deleted the compile_error branch October 30, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants