fix: Add sis_ id prefix for usage record summaries #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arlyon Would it be possible for you to take a look at this? |
|
Oops, thanks for the ping, my notifications have been a mess recently! I will run CI now, thanks for taking the time. |
|
I have pushed a change to fix the CI msrv pin issue, please rebase when you get the chance and ping me when its done :) |
sam-butcher
force-pushed
the
usage_record_summary_id
branch
from
c7dc8a1
to
1042493
Compare
|
@arlyon Done! |
|
@arlyon sorry for pinging again, can I get a bump on CI for this? |
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
=========================================
- Coverage 6.24% 5.83% -0.42%
=========================================
Files 141 140 -1
Lines 21133 21029 -104
=========================================
- Hits 1319 1226 -93
+ Misses 19814 19803 -11
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
All merged! I'll baby-sit the release as well and ping you when it's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
sis_id as an option forUsageRecordSummaryIds, as seen in the Stripe API docs - see the Response example at https://stripe.com/docs/api/usage_records/subscription_item_summary_listChecklist
cargo make fmt