Pin rust version to 1.65 instead of pinning time-core #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlyon
previously requested changes
Aug 18, 2023
timsueberkrueb
force-pushed
the
pin-rust-version-explicitly
branch
from
458e71c
to
b10e5da
Compare
timsueberkrueb
force-pushed
the
pin-rust-version-explicitly
branch
from
b10e5da
to
4472864
Compare
|
looks like |
This was referenced Aug 19, 2023
|
@arlyon done, thank you! |
|
Running CI again, TY |
|
@arlyon the CI failing is an unrelated issue I assume? |
|
Hey @arlyon, any update on this one? Thanks :) |
|
Hey @arlyon, it would be really cool if we could land this and have a new crates.io release containing the fix. Thanks! |
|
Hi there, tests aren't passing and it seems that rustc is segfaulting when used with cargo-llvm-cov. I am going to rip it out, because it just adds another layer of mess. |
|
Fixed in this PR #433 New release to crates coming now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #421 (comment)
Checklist
cargo make fmt