E2E test #263
E2E test #263
Conversation
Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com>
Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com>
Signed-off-by: mohamed <mohamedabdelfatah2027@gmail.com>
| test-e2e: kind docker-build install-cert-manager | ||
| kind load docker-image controller:latest | ||
| test-e2e: dev-setup | ||
| sleep 90 |
There was a problem hiding this comment.
sleep 90 makes me sad -- ideally we could test in someway for cold start vs. already up-and-running
There was a problem hiding this comment.
I think it is smelly too. I put it because the dev-install-controller target fails if some of the dev-setup pods aren't running yet. Can you explain more the cold start part?
There was a problem hiding this comment.
By cold start he means adding some form of "caching" behaviour. To be honest, I wouldn't like this - I think tests should start from scratch always - I.e always "cold start".
Are you able to test when all the dev-setup pods are running?https://www.ibm.com/docs/en/mvi/1.1.1?topic=environment-checking-kubernetes-services-status
There was a problem hiding this comment.
Are you able to test when all the dev-setup pods are running?
The current test cases can run only with dev-setup . I could remove the dev-install-controller and the sleep commands. But I think, as this is an initial setup for E2E testing, we will later need the controller installation which requires all the pods from dev-setup to be up and running.
what do you think ?
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage 84.40% 84.40%
=======================================
Files 13 13
Lines 2533 2533
=======================================
Hits 2138 2138
Misses 278 278
Partials 117 117 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Closes #44
┆Issue is synchronized with this Jira Task by Unito