Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookout - configurable title #2460

Merged
merged 5 commits into from
May 22, 2023
Merged

Conversation

carlocamurri
Copy link
Contributor

@carlocamurri carlocamurri commented May 12, 2023

Allows a configurable title to be specified in the UI config. This is to more easily differentiate between Lookout instances.
Note that this also changes the browser tab title.
Noop if the config field is unset.

image

┆Issue is synchronized with this Jira Task by Unito

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ed0ecaf) 58.47% compared to head (3753703) 58.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2460   +/-   ##
=======================================
  Coverage   58.47%   58.47%           
=======================================
  Files         235      235           
  Lines       29464    29464           
=======================================
  Hits        17230    17230           
  Misses      10913    10913           
  Partials     1321     1321           
Flag Coverage Δ
armada-server 58.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a default if custom not specified?

I see you override or prefix but not clear if custom title is not specified.

@carlocamurri carlocamurri enabled auto-merge (squash) May 15, 2023 13:05
@carlocamurri carlocamurri merged commit 7282bc8 into master May 22, 2023
@carlocamurri carlocamurri deleted the carlocamurri/lookoutv2-custom-title branch May 22, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants