fix setDrawsNotificationsAutomatically #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2014 12:52
this prevented updateServer from being called when draw was disabled no longer necessary as threadedUpdate will prevent calling updateServer on the main thread when in threaded mode
calls ofAddListener/ofRemoveListener in setDrawNotificationsAutomatically this way it can be called before or after setup
|
Hey thx for this! notifications were being drawn regardless of OFX_REMOTEUI_SERVER_SET_DRAWS_NOTIF(); but your fix would disable the whole UI drawing entirely. The redundant bool is a good catch! Im going to close this and fix it on my end |
armadillu
added a commit
that referenced
this pull request
Aug 28, 2014
|
Nice fix, glad to help, really liking this addon. |
|
thx glad you find it useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
Previously setting this to false would prevent the server from being visible, as
updatedThisFramewas only set tofalseindraw. If drawing was disabled this would never happen, andupdateServerwouldn't be called.It appears that
updatedThisFramewas redundant, as it was only used to prevent calls toupdateServeron the main thread when the server was set to threaded mode;threadedUpdatetakes care of this well enough.This update also moves the
ofAddListenertodrawtosetDrawsNotificationsAutomaticallyso that it can be changed on the fly, enabling/disabling notification drawing before or after setup.