Optimizations #104
Merged
Optimizations #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some micro-optimizations, but also something interesting: scheduling cleanup tasks on the
MacrotaskExecutorso that they don't block rendering. This makes a visible difference in the TodoMVC when going from "active" to "completed" with many active todos and few completed todos, as most of the work is cleanup (i.e. deregistering the signals).I'd like to apply the optimization in the reverse direction as well (signal registration as a macrotask), but that is a more complex change I will do in a follow-up.