Parsing json response funcion is now customizable (still defaults to … #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`json.loads`). This allows to implement JSON-RPC class hinting or any other conversions.
In the case where our users aren't specifying a manual json.loads method, we'd rather omit that argument, so that aiohttp can use its logic to determine the default json.loads method.
We're not going to commit to loads being in a particular position in the argument order on our API.
emlove
approved these changes
Sep 3, 2018
|
Great, good point, thanks :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
json.loads).This allows to implement JSON-RPC class hinting or any other conversions.