Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom template reference. #27

Closed
PixelLifetime opened this issue Oct 15, 2020 · 1 comment · Fixed by #40
Closed

Custom template reference. #27

PixelLifetime opened this issue Oct 15, 2020 · 1 comment · Fixed by #40

Comments

@PixelLifetime
Copy link

Is your feature request related to a problem? Please describe.
We want to generate another custom file, something like "component.default.scss" that will hold our "!default" values. But we can't find a way to do it, looking through the code, component types are strictly defined.

Describe the solution you'd like
We would like that to be dynamic, meaning we can add any type of component to be generated given it's path. Like array of paths pointing to templates which will be generated and replaced with keywords.

Describe alternatives you've considered
Additional tool for generation, or custom command to generate it. But we would like to have everything in 1 package for convenience.

Additional context
Making this feature could possibly break compatibility with previous versions of the package if it has to be clean and things like component or lazy would be defined in array and not as constants. But it's also possible to make this as a side feature and keep these types as strict to keep backwards compatibility.

If no one else wants to implement this feature we would like to take it as a good first issue and implement it ourselves, but it would take some time for us to do because it's not a pressing matter right now. But we just need a heads up about if you are ok with this feature and you would accept our pull request.

Thank you!

@PixelLifetime
Copy link
Author

Related to #22. The idea is basically the same, but keeping different attributes and configurations when generating these files.

arminbro added a commit that referenced this issue Feb 16, 2021
This feature will allow for adding custom component file types (e.g., withIndex, withwithStoryStyle,
etc.)

#21 #22 #27 #34 #36 #37 #39
@arminbro arminbro linked a pull request Feb 17, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant