Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AdfState optional #1

Merged
merged 1 commit into from
May 26, 2020
Merged

Make AdfState optional #1

merged 1 commit into from
May 26, 2020

Conversation

jannic
Copy link
Contributor

@jannic jannic commented May 23, 2020

Hey Armin,
thanks for that great tool!

With this trivial patch, I was able to make it work with an HP DeskJet 3070A, which doesn't have an automatic document feeder.

With this change, scanning works with an HP DeskJet 3070A, which doesn't
have an automatic document feeder.
@arminha
Copy link
Owner

arminha commented May 26, 2020

That's a nice addition, thanks!

I knew there are other HP printers using a similar API for scanning, but didn't know about the differences.
Building on this it should also be possible to hide the option to select an input source in the web UI if the printer doesn't support it. Created issue #3 to track that.

@arminha arminha merged commit c789012 into arminha:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants