Concurrent publishing and custom content type on serializer. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mackross The publisher and consumers are purposely not concurrent safe. Instead the pattern is to make a new publisher for each go-routine. For the content-type, it's purposely an interface, so you should just implement a Serializer that sets a custom type. |
|
On concurrency this slows down the publish rate as you're not taking advantage of multi-ack confirms. |
|
I understand, but my goal with this library was simplicity instead of maximum performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch still needs to be integrated into my project and tested but I would love feedback and a second set of eyes to go over the changes.