feat(builder): add feature flag to restrict app updates #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After talking to Jason a bit about it, pipeline 'runAs' and 'Permissions' will probably also need to be ignored after all. Otherwise, any user with access to the dinghy repo can set any permission level (service account) for the pipeline. |
dogonthehorizon
force-pushed
the
exp/lock-pipeline-updates
branch
4 times, most recently
from
de1a657
to
9105577
Compare
Dinghy runs withs service account permissions that cannot be changed at runtime. This can create situations where permissions for a given app restrict actions in the UI that can be changed by Dinghy. For this reason, we're introducing a new feature flag that, when enabled, will restrict application and pipeline updates to the repository that created the app/pipeline combo first. This prevents the scenario where Team A defines a pipeline for their application, and Team B copy/pastes their pipeline definition into a separate repository. If not careful, this could clobber Team A's work and cause confusion/friction in the deployment process. This feature flag is currently only implemented for GitHub providers.
dogonthehorizon
force-pushed
the
exp/lock-pipeline-updates
branch
from
9105577
to
38b6174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dinghy runs withs service account permissions that cannot be changed at
runtime. This can create situations where permissions for a given app
restrict actions in the UI that can be changed by Dinghy.
For this reason, we're introducing a new feature flag that, when
enabled, will restrict application and pipeline updates to the
repository that created the app/pipeline combo first. This prevents the
scenario where Team A defines a pipeline for their application, and Team
B copy/pastes their pipeline definition into a separate repository. If
not careful, this could clobber Team A's work and cause
confusion/friction in the deployment process.
This feature flag is currently only implemented for GitHub providers.
Still TODO before we can merge this PR:
Implement permissions lock flagNot in scope for this PR