Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(errsend): send events even when we error #56

Merged
merged 3 commits into from
Jul 25, 2019

Conversation

jeffhart-armory
Copy link
Contributor

No description provided.

Copy link
Contributor

@staciegravy staciegravy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffhart-armory jeffhart-armory merged commit 68a1800 into master Jul 25, 2019
justinrlee pushed a commit that referenced this pull request Mar 18, 2020
* chore(errsend): send events even when we error

* also send logs to stdout

* fix tests
dogonthehorizon pushed a commit that referenced this pull request Mar 30, 2021
* chore(errsend): send events even when we error

* also send logs to stdout

* fix tests
@sergio-quintero sergio-quintero deleted the jeff/ENG-4451 branch August 22, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants