fix(github): Change ref of github to master from refs/heads/master #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it to the redis keys
pkg/git/github/push.go
Outdated
| @@ -114,6 +114,9 @@ func (p *Push) IsBranch(branchToTry string) bool { | |||
|
|
|||
| // IsMaster detects if the branch is master. | |||
| func (p *Push) IsMaster() bool { | |||
| if(p.Ref) == "master" { | |||
| return true; | |||
There was a problem hiding this comment.
Can be simplified by return p.Ref == "master" || p.Ref == "refs/heads/master"
dogonthehorizon
pushed a commit
that referenced
this pull request
Mar 30, 2021
* Change ref of github to master from refs/heads/master to avoid adding it to the redis keys * fix(github): not replace branch for master, but just remove the ref/heads part of it * fix(github): pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dinghy was saving parents keys as:
Armory:dinghy:children:https://api.github.com/repos/armory-io/karlo-test/contents/dinghy/dinghyfile?ref=refs/heads/master
And searching for them as:
Armory:dinghy:parents:https://api.github.com/repos/armory-io/karlo-test-dinghy/contents/stage.test.module?ref=master
Removed the "refs/heads/" from the branch for github pushes.